Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize make_aggsig_final_message() #682

Merged
merged 2 commits into from
Aug 29, 2024
Merged

Optimize make_aggsig_final_message() #682

merged 2 commits into from
Aug 29, 2024

Conversation

matt-o-how
Copy link
Contributor

Reduce Vec allocations in validate_clvm_and_signature() by clearing and re-using the same Vecs

@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Aug 27, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10598086762

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 28 of 29 (96.55%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 83.895%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/chia-consensus/src/gen/make_aggsig_final_message.rs 19 20 95.0%
Totals Coverage Status
Change from base Build 10575607681: 0.004%
Covered Lines: 12304
Relevant Lines: 14666
💛 - Coveralls

@matt-o-how matt-o-how requested a review from arvidn August 27, 2024 18:14
arvidn
arvidn previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@arvidn arvidn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

crates/chia-consensus/src/gen/make_aggsig_final_message.rs Outdated Show resolved Hide resolved
@matt-o-how matt-o-how merged commit c134fed into main Aug 29, 2024
59 checks passed
@matt-o-how matt-o-how deleted the optimize_aggsig_final branch August 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rigidity Rigidity Rigidity approved these changes

@arvidn arvidn arvidn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matt-o-how @arvidn @Rigidity